Repair deferred updates and other cleanup #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
reviewed
Jul 22, 2022
| @@ -835,9 +835,18 @@ public partial class MainWindow : Window { | |||
| if ("installationupdate".Equals(evt.Message?.ToLower())) { | |||
| logger.Debug("Installation Update is available - {0}", evt.ZDEVersion); | |||
| IsUpdateAvailable = true; | |||
| MainMenu.ShowUpdateAvailable(evt.TimeRemaining, evt.InstallTime); | |||
There was a problem hiding this comment.
was TimeRemaining bogus? or does it mean something else? should it be removed?
There was a problem hiding this comment.
It was utterly superfluous and i removed it from the json object the montior service sends, yes. It was replaced by a simple "now - installtime" calculation (which is already there):
var remaining = evt.InstallTime - DateTime.Now;
...
MainMenu.ShowUpdateAvailable(remaining.TotalSeconds, evt.InstallTime);
scareything
reviewed
Jul 22, 2022
| if ((""+level).ToLower() == "verbose") | ||
| { | ||
| level = "trace"; | ||
| Logger.Info("request to change log level to verbose - but using trace instead"); |
There was a problem hiding this comment.
why not respect "verbose" ?
There was a problem hiding this comment.
NLog doesn't have the level
dovholuknf
commented
Jul 22, 2022
| public String ZDEVersion { get; set; } | ||
| public DateTime CreationDate { get; set; } | ||
| public string ZDEVersion { get; set; } | ||
| /*public DateTime CreationDate { get; set; } |
There was a problem hiding this comment.
i'll just delete this dead code - this is where TimeRemaining was
scareything
reviewed
Jul 22, 2022
ZitiUpdateService/App.config
Outdated
| This duration probably should not be smaller than the UpdateTimer. If a value is provided that is smaller than the UpdateTimer. | ||
| If the value is smaller than the UpdateTimer duration, it will nag the user every time the update check detects a new udpate. | ||
|
|
||
| It is recommended to keep this value some multiplier of the UpdateTimer. |
scareything
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #541
closes #474
closes #396