Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience to client ext jwt #143

Closed
wants to merge 3 commits into from

Conversation

dovholuknf
Copy link
Member

the tests failed when I ran generate_rest.sh but my local failures appeared unrelated, so I pushed this up to get feedback anyway...

@dovholuknf dovholuknf requested a review from a team as a code owner January 17, 2025 12:56
@dovholuknf dovholuknf force-pushed the add-audience-to-client-ext-jwt branch from 15fc0a1 to 9986670 Compare January 17, 2025 13:02
Copy link
Member

@andrewpmartinez andrewpmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears you edited the generated files and not the source files.

  1. Edit source files
  2. Bump version (usually minor)
  3. Generate using tooling

See the readme.md.

@dovholuknf
Copy link
Member Author

i DID read the readme fwiw... Im just starting this all over and rm'ing this branch...

@dovholuknf dovholuknf closed this Jan 17, 2025
@dovholuknf dovholuknf deleted the add-audience-to-client-ext-jwt branch January 17, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants