codespell: Add spelling check and fix all issues #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
Thank you for your contribution! |
ekoby
reviewed
Dec 18, 2023
| @@ -18,7 +18,7 @@ spawn $ziti edge quickstart --home $env(QUICKSTART_HOME) | |||
| set qs_id @spawn_id | |||
| # wait until ER is connected | |||
| expect { | |||
| "finished sychronizing api sessions" { } | |||
There was a problem hiding this comment.
this typo is needed as it is the output from another project.
with the fix expect won't find the right output
There was a problem hiding this comment.
if you also wish to fix that -- it is here:
https://github.com/openziti/ziti/blob/42f6e3fc487b70970b4b6f57b0af72ebf06a65df/router/handler_edge_ctrl/apiSessionAdded.go#L124
There was a problem hiding this comment.
@ekoby thank you. I´ve created a PR there, see openziti/ziti#1652
ekoby
reviewed
Dec 18, 2023
| @@ -12,12 +12,12 @@ spawn $ziti edge quickstart --already-initialized --home $env(QUICKSTART_HOME) | |||
| set qs_id $spawn_id | |||
|
|
|||
| expect { | |||
| "finished sychronizing api sessions" { } | |||
ekoby
requested changes
Dec 18, 2023
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
ekoby
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a trivial PR, adding the codespell tool to the CI, and fixing some non-code misspelling cases.
The CI file is called
linters.yml, so that this can be extended in a future with other linter tools.Best regards,
Mario