Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend identity cert #823

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Extend identity cert #823

merged 5 commits into from
Feb 7, 2025

Conversation

ekoby
Copy link
Member

@ekoby ekoby commented Feb 6, 2025

in order to enable identity certificate auto-extension, an application must do the following:

  • set ziti_option.enable_cert_extension and handle ZitiConfigEvent
  • applicaiton must save the new certificate chain delivered as part of ZitiConfigEvent

[fixes #700]

@ekoby ekoby requested a review from a team as a code owner February 6, 2025 21:25
@ekoby ekoby added the minor bump minor version label Feb 6, 2025
library/ziti.c Outdated
time_t now = time(0);
time_t exptime = mktime(&exp);

bool renew = exptime - now < TEN_DAYS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make TEN_DAYS a config option on ziti_options_s and let the tunneler/client control this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this better?

@ekoby ekoby merged commit 05fdd32 into main Feb 7, 2025
15 checks passed
@ekoby ekoby deleted the extend-identity-cert branch February 7, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor bump minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement client certificate auto-extension
2 participants