Remove common header type from xgress messages since the overlap isn't complete #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
force-pushed
the
no-common-xg-header
branch
2 times, most recently
from
2e04654
to
66caaaa
Compare
plorenz
force-pushed
the
no-common-xg-header
branch
from
66caaaa
to
776db43
Compare
plorenz
commented
Sep 19, 2024
There was a problem hiding this comment.
Only change should be renaming retransmitter to self
plorenz
commented
Sep 19, 2024
There was a problem hiding this comment.
Allow replacing the acker in tests
michaelquigley
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.