Crash when calling zrok share reserved without shareToken

[rossvz]

The Zrok docs mention just running zrok share reserved after creating a reserved instance.

However, when I ran that I get the following:

❯ zrok share reserved
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.(*shareReservedCommand).run(0x0?, 0x6df3a3eb00000000?, {0x10655dfe0?, 0x0?, 0x0?})
	github.com/openziti/zrok/cmd/zrok/shareReserved.go:49 +0x1564
github.com/spf13/cobra.(*Command).execute(0x14001014c08, {0x10655dfe0, 0x0, 0x0})
	github.com/spf13/cobra@v1.8.0/command.go:987 +0x828
github.com/spf13/cobra.(*Command).ExecuteC(0x1063d48a0)
	github.com/spf13/cobra@v1.8.0/command.go:1115 +0x344
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.8.0/command.go:1039
main.main()
	github.com/openziti/zrok/cmd/zrok/main.go:106 +0x24

Looking in the error message I went to the source file here

and realized it's expecting an argument. After the fact I saw that the help text usage implies the <shareToken> but a more helpful error message would be appreciated.

Note - I tried cloning this and fixing myself but I dont think I understand enough about the project to get the error message showing correctly.

[michaelquigley]

Nice find. It's a one-liner fix. Will include a fix in the next v0.4 release.