Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeJS sdk #589

Merged
merged 24 commits into from
May 1, 2024
Merged

NodeJS sdk #589

merged 24 commits into from
May 1, 2024

Conversation

rentallect
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
zrok ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 7:33pm

michaelquigley
michaelquigley requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to work for vanilla JavaScript folks? We definitely want this to work without TypeScript.

bin/generate_rest.sh Outdated Show resolved Hide resolved
sdk/nodejs/examples/http-server/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/examples/pastebin/package.json Outdated Show resolved Hide resolved
@rentallect
Copy link
Member Author

Is this going to work for vanilla JavaScript folks? We definitely want this to work without TypeScript.

Yes, even though the nodejs SDK is implemented in TypeScript, it will work for pure JS consumers. The reason is that the packaged sdk artifact is compiled back to pure JS, and that is what a consumer will interface with.

@michaelquigley
Copy link
Collaborator

Is this going to work for vanilla JavaScript folks? We definitely want this to work without TypeScript.

Yes, even though the nodejs SDK is implemented in TypeScript, it will work for pure JS consumers. The reason is that the packaged sdk artifact is compiled back to pure JS, and that is what a consumer will interface with.

Assumed so! Just wanted to double-check.

@rentallect rentallect marked this pull request as ready for review March 28, 2024 14:00
michaelquigley
michaelquigley requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer!

sdk/nodejs/examples/http-server/package.json Show resolved Hide resolved
sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/sdk/package.json Show resolved Hide resolved
sdk/nodejs/sdk/src/environment/root.ts Outdated Show resolved Hide resolved
sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
michaelquigley
michaelquigley requested changes May 1, 2024
View reviewed changes
sdk/nodejs/examples/http-server/src/index.ts Outdated Show resolved Hide resolved
sdk/nodejs/sdk/package.json
@@ -0,0 +1,52 @@
{
"name": "@openziti/zrok",
"version": "0.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this still 0.1.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version gets auto-updated by the GH Action that runs whenever the main branch gets updated, and the semver will become whatever the prevailing git tag is at the time. The package that gets published to NPM will have the same version as the zrok repo's git tag.

sdk/nodejs/examples/pastebin/src/index.ts Outdated Show resolved Hide resolved
michaelquigley
michaelquigley approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@michaelquigley
Copy link
Collaborator

#400

@michaelquigley michaelquigley merged commit 7d2ae34 into main May 1, 2024
11 checks passed
@michaelquigley michaelquigley deleted the node-sdk branch May 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelquigley michaelquigley michaelquigley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rentallect @michaelquigley @camotts