Ionosphere correction #102

seongsujeong · 2023-03-07T00:56:10Z

This PR adds ionosphere correction feature to COMPASS. Currently I label this PR work in progress because there are some points that needs to be coordinated with the pending PRs in COMPASS.
Below are few notes:

For comparison purpose (with the ISCE3 equivalent in PR #1251 in the internal GitHub), static troposphere correction was added. It is TBD whether or not to keep it.
IONEX file is provided as one of dynamic ancillary files in runconfig.
Current behavior regarding IONEX is that it raises an error when correction_luts is enabled but IONEX file was not provided, or does not exist.
It re-uses lat / lon / incidence angle rasters in radar grid. The current commit in this PR runs rdr2geo when calculating azimuth FM rate mismatch.
4.1. Eventually solid earth tide computation (in the PR Solid Earth Tides correction #91 ) will run rdr2geo. This run will generate latitude, longitude, height, incidence angle, and heading to be used for other corrections, which are:
- Solid Earth Tide
- azimuth FM mismatch rate
- ionosphere correction
- troposphere correction in python level (Either static or weather model-based)

Updating branch `docker` in this fork to date

…o_s1_geocode_slc

Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov>

Co-authored-by: Liang Yu <liangjyu@gmail.com>

…sujeong/COMPASS into eap_correction_into_s1_geocode_slc

This reverts commit d2d5971, reversing changes made to b5e9341.

Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>

…mitigation`

…orrection

seongsujeong · 2023-03-10T05:10:05Z

@vbrancat @LiangJYu @hfattahi I think the PR is ready for review.

vbrancat

Thank you @seongsujeong. I did not have time to test the PR, unfortunately. However, I provided some comments. Do you mind sharing the TEC file for Rosamond. This might make testing much faster. Thank you :)

vbrancat · 2023-03-11T00:08:56Z

src/compass/defaults/s1_cslc_geo.yaml

@@ -17,6 +17,8 @@ runconfig:
      dynamic_ancillary_file_group:
          # Digital elevation model
          dem_file:
+          # IONEX file for ionosphere correction
+          ionex_file:


Ionex is a file format, let's rename this to something more descriptive e.g. tec_file . Also let's add documentation of what this file is e.g. GNSS total electron content file in Ionex format

This is what was done in nisar

vbrancat · 2023-03-11T00:11:19Z

src/compass/utils/lut.py

    descr = ['geometrical doppler', 'bistatic delay', 'azimuth FM rate mismatch',
-             'slant range Solid Earth tides']
+             'slant range Solid Earth tides', 'ionospheric delay']


Let's specify that the ionosphere is along the LOS.

Good idea. For consistency, what do you think about adding azimuth or slant range for the first three corrections? i.e. geometrical doppler, bistatic delay, and azimuth FM rate mismatch

I agree, it is a good idea.

vbrancat · 2023-03-11T00:13:01Z

src/compass/utils/lut.py

@@ -362,3 +367,55 @@ def resample_set(geo_tide, pts_src, pts_dest):
                   bounds_error=False, fill_value=0)
    rdr_tide = rgi_func(pts_dest)
    return rdr_tide
+
+
+def ionosphere_delay(sensing_time, wavelength,


The input of the function should be generic. I assume here you need a date to be provided in a certain format not necessarily the burst sensing start.

isce3 uses UTC time.

Also, I think this function is a better fit in iono.py.

Thanks for the suggestion. I agree the placement of this function, and generic input for the time component of this function. For that I've moved the function into iono.py, and renamed sensing_time into utc_time
For the data type of utc_time I think I prefer to keep datetime.datetime. What do you think?

Yeah, I like having the data type of utc_time to be datatime.datetime (let's clarify it in a comment or in the docstring), what do you think @LiangJYu ?

datetime.datetime sounds good to me.

vbrancat · 2023-03-11T00:15:06Z

src/compass/utils/lut.py

+
+    Returns
+    -------
+    slant_range_delay: np.ndarray


Let's rename this variable to reflect that this is a LOS ionosphere delay

vbrancat · 2023-03-11T00:19:12Z

src/compass/utils/lut.py

+        Ionospheric delay in slant range
+    '''
+
+    if not ionex_path:


It is ok to have this check inside the function but we need to discuss what is the default behavior. If a user wants to generate a CSLC-S1 does he/she need to always provide a TEC file?

Good point. In the use case above, I think the user still cat get the CSLC-S1 output without providing TEC file by setting correction_luts.enabled in runconfig to False. In that case lut.cumulative_correction_luts() does not get triggered.
In that case, however, all other LUT-based corrections will be turned off (e.g. bistatic delay, azimuth FM rate mismatch, SET, tropo, etc.) I think we might need to discuss whether someone might want to turn on / off each individual components of the LUT correction.

I decided to put the IONEX file check here because reaching to this point means that the workflow is about to apply ionosphere correction, and TEC file is mandatory in this case.
One thing I am not certain is, whether we would raise an error to stop the processing, or just return zero-filled array and warn the users. My preference is to raise the flag.

Let's resume the discussion on the default behavior in our next meeting. In the meantime, we do not want the user to get until here if the TEC file has not been provided. I recommend adding a check in geo_runconfig.py similarly to what has been done here https://github.com/vbrancat/COMPASS/blob/016eb4d762b440ba0609e9a8f5fd495a14e8f55a/src/compass/utils/geo_runconfig.py#L73 so that we stop the SAS immediately if the TEC file is not provided

With respect to the SAS default behavior, just a heads up, I remember we decided to support an interface where the provided path to the TEC file might be None. If I remember correctly, we want still apply the other corrections but only apply the ionosphere correction if the path to the TEC file is provided in the runconfig

@vbrancat Thanks for the suggestion and information. I've added the check in geo_runconfig.py for TEC file. Also, in iono.ionosphere_delay(), I've modified it to return a zero-filled array when tec_file is None to keep the workflow going without ionosphere correction.

if not tec_file: print('"tec_file" was not provided. ' 'Ionosphere correction will not be applied.') return np.zeros(lon_arr.shape)

vbrancat · 2023-03-11T00:21:29Z

src/compass/utils/lut.py

+    '''
+
+    if not ionex_path:
+        raise RuntimeError('LUT correction was enabled, '


Irrespective of the setting for the corrections, if ionex_path is not provided, we cannot perform the correction. The error message should reflect that and be independent of the correction settings. Also, let's check directly that the path exists

I agree that the error message should be independent to the correction setting. Please take a look how the revised message looks like.

For file existence check, I think we might better to keep the current pattern because os.path.exists(None) will raise an error like below. Also this early-return pattern will make it easier to read.

os.path.exists(None)
Traceback (most recent call last):
File "", line 1, in
File "/Users/jeong/miniconda3/lib/python3.9/genericpath.py", line 19, in exists
os.stat(path)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

Addressed as mentioned in the comment above.

vbrancat · 2023-03-11T00:22:34Z

src/compass/utils/lut.py

+    ionex_val = ionex_val.reshape(lon_arr.shape)
+
+    freq_sensor = isce3.core.speed_of_light / wavelength
+    electron_per_sqm = ionex_val * 1e16


Let's add a comment why we need to do this conversion

The comments for K and electron_per_sqm was copied from nisar. Also the name of the constant was capitalized to show that this is constant.

vbrancat · 2023-03-11T00:26:57Z

src/compass/utils/h5_helpers.py

@@ -608,6 +608,9 @@ def corrections_to_h5group(parent_group, burst, cfg, rg_lut, az_lut,
            Meta('los_solid_earth_tides', ds.GetRasterBand(4).ReadAsArray(),
                 f'Solid Earth tides (range) {desc}',
                 {'units': 'meters'}),
+            Meta('ionospheric_delay', ds.GetRasterBand(5).ReadAsArray(),
+                 f'Ionospheric delay {desc}',


Let's add the direction of the ionosphere delay

src/compass/utils/lut.py

LiangJYu

Not much to add beyond what @vbrancat already commented on.

LiangJYu · 2023-03-12T19:47:29Z

src/compass/defaults/s1_cslc_geo.yaml

@@ -17,6 +17,8 @@ runconfig:
      dynamic_ancillary_file_group:
          # Digital elevation model
          dem_file:
+          # IONEX file for ionosphere correction
+          ionex_file:


This is what was done in nisar

LiangJYu · 2023-03-13T00:46:04Z

src/compass/utils/lut.py

@@ -362,3 +367,55 @@ def resample_set(geo_tide, pts_src, pts_dest):
                   bounds_error=False, fill_value=0)
    rdr_tide = rgi_func(pts_dest)
    return rdr_tide
+
+
+def ionosphere_delay(sensing_time, wavelength,


isce3 uses UTC time.

Also, I think this function is a better fit in iono.py.

LiangJYu · 2023-03-13T19:26:34Z

Not immediately relevant to this PR: @seongsujeong @vbrancat what do you all think consolidating ionosphere functionality (and maybe other atmospheric corrections) within ISCE3?

vbrancat

Some more small comments

vbrancat · 2023-03-13T19:41:14Z

src/compass/utils/lut.py

@@ -27,6 +27,8 @@ def cumulative_correction_luts(burst, dem_path,
        Sentinel-1 A/B burst SLC object
    dem_path: str
        Path to the DEM file
+    tec_path: str
+        Path to the TEC file for ionosphere correction


Let's specify the file format for the expected TEC file

vbrancat · 2023-03-13T19:41:44Z

src/compass/utils/lut.py

@@ -44,16 +46,17 @@ def cumulative_correction_luts(burst, dem_path,
        and slant range
    '''
    # Get individual LUTs
-    geometrical_steer_doppler, bistatic_delay, az_fm_mismatch, [tide_rg, _]= \
+    geometrical_steer_doppler, bistatic_delay, az_fm_mismatch, [tide_rg, _], ionosphere = \


let's identify the variable as los_ionosphere

vbrancat · 2023-03-13T19:42:24Z

src/compass/utils/lut.py

        LUT spacing along x/slant range in meters
-    ystep: int
+    az_ystep: float


This does not reflect the name of the function variable

Suggested change

az_ystep: float

az_step: float

Thanks for catching this. That was a typo.

LiangJYu

LGTM nothing to add beyond what @vbrancat commented on.

LiangJYu · 2023-03-14T02:38:49Z

src/compass/utils/lut.py

        LUT spacing along x/slant range in meters
-    ystep: int
+    az_ystep: float


Suggested change

az_ystep: float

az_step: float

vbrancat

LGTM, thanks @seongsujeong

…orrection

@LiangJYu

* Mod on Dockerfile for cslc_s1 point release and few improvement * Docker image size optimized * Removing the commands in the header comment * Initial commit after branch-out * minor fix; metadata writeout * Update src/compass/utils/elevation_antenna_pattern.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/elevation_antenna_pattern.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Comments on PR addressed; docstring for `apply_eap_correction` fixed * comment clarification * comment clarification * addressing codacy issues * Applying EAP correction (or skip) before `range_split_spectrum` * addressing codacy issue * metadata field name changed * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * converting burst ID to `str` * using EPSG from geogrid, not from input DEM * Revert "Merge branch 'eap_correction_into_s1_geocode_slc'" This reverts commit d2d5971, reversing changes made to b5e9341. * adding azimuth FM rate mismatch into lut.py * docstring fixed; variable name changed * docstring for file added; raise error when DEM is not valid * Update src/compass/utils/lut.py Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * updates on local * returning az_lut as `isce3.core.LUT2d()` code based on the suggestion from @LiangJYu * docstring revised * removing redundant renaming of the variables * Dockerfile for beta release * Specfile updated * specifile updated * tag on beta.Dockerfile updated * specifile updated * typo fix * beta.Dockerfile updated * updates on `s1_geocode_slc.py` * but fix * updates on beta.Dockerfile * Dockerfile renamed * untested writing az/rg correction LUT to hdf5 moved EAP to corrections group * restructed HDF5 LUT data not working yet * fix doppler return type clean up debugs * fix paths * fix correction group organization * camel to snake fix correction spacing * restore s1_burst_metadata reorg doppler corrections * PEP8 and syntax fixes * fix correction grouping * specfile updated * Specfile updated * s1-reader version updated * Added `0.2` into `version.Tag` * remove radar grid usage from geo grid orbit item names all snake correction reorg * fix CSLC raster validation * fix typo Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/lut.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * docstring revised * ref -> reference w/r/t _epoch add spacing datasets add metadata path comparision in validation * fix burst border _ID to _id added more metadata to enable RadarGridProduct reconstruction * Separate bistatic and azimuth FM rate * change function return unpacking * add all parameters needed to reconstruct burst object * wrap value assignment with try+except move helper to helpers up top for visibility * burst DB now static correct h5 write exception type * fix burst.center type * fix writing empty burst polynomials * fix misformed poly1d items * rename geocoding interpolator item * move runconfig * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * fix product name * add az fm rate mismatch into `h5_helpers.py` * reverting s1_geocode_slc.py * reverting `lut.py` * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * spelling error * fix descriptions * Version number changed * add `validate_cslc.py` to `setup.cfg` * Flexibility on Docker's entrypoint to run the validation script * PEP8 * add entrypoint to `validate_cslc.py` * fix on `setup.cfg` * Update src/compass/utils/validate_cslc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Change version for s1-reader * Removing default value for `dem_path` * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * release date updated for `0.1.3` * Change base Docker image into Oracle Linux * typo fix * Write `NaN` into HDF5 instead of `None` for metadata (opera-adt#82) * Mod on Dockerfile for cslc_s1 point release and few improvement * Docker image size optimized * Removing the commands in the header comment * Initial commit after branch-out * minor fix; metadata writeout * Update src/compass/utils/elevation_antenna_pattern.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/elevation_antenna_pattern.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Comments on PR addressed; docstring for `apply_eap_correction` fixed * comment clarification * comment clarification * addressing codacy issues * Applying EAP correction (or skip) before `range_split_spectrum` * addressing codacy issue * metadata field name changed * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * converting burst ID to `str` * using EPSG from geogrid, not from input DEM * Revert "Merge branch 'eap_correction_into_s1_geocode_slc'" This reverts commit d2d5971, reversing changes made to b5e9341. * adding azimuth FM rate mismatch into lut.py * docstring fixed; variable name changed * docstring for file added; raise error when DEM is not valid * Update src/compass/utils/lut.py Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * updates on local * returning az_lut as `isce3.core.LUT2d()` code based on the suggestion from @LiangJYu * docstring revised * removing redundant renaming of the variables * Dockerfile for beta release * Specfile updated * specifile updated * tag on beta.Dockerfile updated * specifile updated * typo fix * beta.Dockerfile updated * updates on `s1_geocode_slc.py` * but fix * updates on beta.Dockerfile * Dockerfile renamed * untested writing az/rg correction LUT to hdf5 moved EAP to corrections group * restructed HDF5 LUT data not working yet * fix doppler return type clean up debugs * fix paths * fix correction group organization * camel to snake fix correction spacing * restore s1_burst_metadata reorg doppler corrections * PEP8 and syntax fixes * fix correction grouping * specfile updated * Specfile updated * s1-reader version updated * Added `0.2` into `version.Tag` * remove radar grid usage from geo grid orbit item names all snake correction reorg * fix CSLC raster validation * fix typo Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/lut.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * docstring revised * ref -> reference w/r/t _epoch add spacing datasets add metadata path comparision in validation * fix burst border _ID to _id added more metadata to enable RadarGridProduct reconstruction * Separate bistatic and azimuth FM rate * change function return unpacking * add all parameters needed to reconstruct burst object * wrap value assignment with try+except move helper to helpers up top for visibility * burst DB now static correct h5 write exception type * fix burst.center type * fix writing empty burst polynomials * fix misformed poly1d items * rename geocoding interpolator item * move runconfig * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * fix product name * add az fm rate mismatch into `h5_helpers.py` * reverting s1_geocode_slc.py * reverting `lut.py` * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * Update src/compass/utils/h5_helpers.py Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * spelling error * fix descriptions * Version number changed * add `validate_cslc.py` to `setup.cfg` * Flexibility on Docker's entrypoint to run the validation script * PEP8 * add entrypoint to `validate_cslc.py` * fix on `setup.cfg` * Update src/compass/utils/validate_cslc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Change version for s1-reader * Removing default value for `dem_path` * Update src/compass/utils/lut.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * release date updated for `0.1.3` * Change base Docker image into Oracle Linux * typo fix * write NaN instead of None Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> Co-authored-by: Zhang Yunjun <yunjunzgeo@gmail.com> * Apply corrections in geocodeSlc module (opera-adt#78) * Add Boolean flag to acitivate/disactivate LUT corrections * Feed LUT corrections to geocode SLC * Save LUTs in CSLC product when computed, skip otherwise * Remove trailing space * Add cumulative LUT function * Modify CSLC validation script (opera-adt#77) * Throw error when percentage of pixels is above threshold * Address comments on threshold and relative difference: * Specify threshold in the print message. Suppress numpy warnings * Use masked array; modify failed pixel percentage computation * Use masked array to compute NaNs * Correct division by reference pixels * More verbose way to compute absolute difference * compare raster per pixel use masked arrays assign thresholds to variables report on both real and imag % fails Co-authored-by: Liang Yu <liangjyu@gmail.com> * make common burst filtering optional in stack processor (opera-adt#60) * make common burst filtering optional in stack processor * also add gix for bad function name * Update dependencies (opera-adt#88) * Add pandas dependency * add lmxl * Include default values in runconfig written to HDF5 metadata (opera-adt#87) * add default options to metadata runconfig str * Update src/compass/utils/runconfig.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Unit test for IONEX functionalities (opera-adt#80) * Unit test for IONEX functionalities * Add ionex unit test data * adopt pytest fixtures * Allocate variables in conftest * rewrite Docker command * Test with pytest in circleci docker - moved copy of source after miniconda install * fix tec URL * ionospheric correction - working version * `ionex_file` added into `dynamic_ancillary_file_group` in runconfig * Interface revision for iono / tropo corrections; test code removed * `ionex_path` added * shortcut to ionex path in cfg * reverting the changes in parameters for calling `az_fm_rate_mismatch_mitigation` * ionospheric correction writeout to CSLC * removed unnecessary lines * fixing codacy issue * PEP8 issue * updating runconfig template for CI * revision on runconfig scheme and defaults * PR comments addressed * docstring revised * revision on the description in corrections * addressing comments in the 2nd round review * PEP8 --------- Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> Co-authored-by: Zhang Yunjun <yunjunzgeo@gmail.com> Co-authored-by: Scott Staniewicz <scott.j.staniewicz@jpl.nasa.gov>

Seongsu Jeong and others added 30 commits July 28, 2022 10:35

Mod on Dockerfile for cslc_s1 point release and few improvement

3d7c5bb

Merge pull request #6 from opera-adt/main

541721c

Updating branch `docker` in this fork to date

Merge branch 'main' of github.com:opera-adt/COMPASS into docker

86724cd

Docker image size optimized

a5d1961

Removing the commands in the header comment

1cbcd5d

Initial commit after branch-out

04f8427

minor fix; metadata writeout

4cada71

Merge remote-tracking branch 'opera-adt/main' into eap_correction_int…

87b48a8

…o_s1_geocode_slc

Update src/compass/utils/elevation_antenna_pattern.py

1ffa745

Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov>

Update src/compass/utils/elevation_antenna_pattern.py

c2d5e28

Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov>

Comments on PR addressed; docstring for apply_eap_correction fixed

8430c07

comment clarification

4521971

comment clarification

b776b52

addressing codacy issues

bb0c21e

Applying EAP correction (or skip) before range_split_spectrum

832d415

addressing codacy issue

a5c2a7e

metadata field name changed

f04762b

Update src/compass/s1_geocode_slc.py

05cc56a

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Update src/compass/s1_geocode_slc.py

0405bb9

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Update src/compass/s1_geocode_slc.py

4f59383

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Update src/compass/s1_geocode_slc.py

ecafe57

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Merge branch 'eap_correction_into_s1_geocode_slc' of github.com:seong…

05c9af8

…sujeong/COMPASS into eap_correction_into_s1_geocode_slc

converting burst ID to str

431f432

using EPSG from geogrid, not from input DEM

228d936

Merge branch 'eap_correction_into_s1_geocode_slc'

d2d5971

Revert "Merge branch 'eap_correction_into_s1_geocode_slc'"

42f1a1c

This reverts commit d2d5971, reversing changes made to b5e9341.

adding azimuth FM rate mismatch into lut.py

76121c5

docstring fixed; variable name changed

2640cce

docstring for file added; raise error when DEM is not valid

d8060ae

Update src/compass/utils/lut.py

cbff3c2

Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>

seongsujeong requested review from LiangJYu, hfattahi and vbrancat March 7, 2023 00:56

Seongsu Jeong added 4 commits March 9, 2023 15:47

reverting the changes in parameters for calling `az_fm_rate_mismatch_…

7df20dc

…mitigation`

Merge branch 'main' of github.com:opera-adt/COMPASS into ionosphere_c…

cf69230

…orrection

ionospheric correction writeout to CSLC

18d3a11

removed unnecessary lines

b9111e8

seongsujeong removed the work in progress label Mar 10, 2023

Seongsu Jeong added 3 commits March 9, 2023 16:56

fixing codacy issue

41563bf

PEP8 issue

6592d0a

updating runconfig template for CI

34587aa

seongsujeong changed the title ~~WIP: Ionosphere correction~~ Ionosphere correction Mar 10, 2023

vbrancat reviewed Mar 11, 2023

View reviewed changes

LiangJYu reviewed Mar 13, 2023

View reviewed changes

Seongsu Jeong added 4 commits March 13, 2023 12:02

revision on runconfig scheme and defaults

159e53d

PR comments addressed

cf783dd

docstring revised

9828465

revision on the description in corrections

49e7c7e

vbrancat reviewed Mar 13, 2023

View reviewed changes

This was referenced Mar 13, 2023

WIP: azimuth component calculation of solid earth tide #105

Closed

Few reminders and TODOs for finalization of LUT correction #106

Closed

LiangJYu approved these changes Mar 14, 2023

View reviewed changes

Seongsu Jeong added 2 commits March 13, 2023 22:55

addressing comments in the 2nd round review

7ba6cfc

PEP8

7c9888f

vbrancat approved these changes Mar 15, 2023

View reviewed changes

Merge branch 'main' of github.com:opera-adt/COMPASS into ionosphere_c…

d2eff2d

…orrection

seongsujeong merged commit a44cc31 into opera-adt:main Mar 16, 2023

Ionosphere correction #102

Ionosphere correction #102

Conversation

seongsujeong commented Mar 7, 2023

seongsujeong commented Mar 10, 2023

vbrancat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbrancat Mar 13, 2023 • edited Loading

Choose a reason for hiding this comment

seongsujeong Mar 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LiangJYu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LiangJYu commented Mar 13, 2023

vbrancat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LiangJYu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbrancat left a comment

Choose a reason for hiding this comment

vbrancat Mar 13, 2023 •

edited

Loading

seongsujeong Mar 14, 2023 •

edited

Loading