Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: azimuth component calculation of solid earth tide #105
WIP: azimuth component calculation of solid earth tide #105
Changes from 4 commits
ebe5bde
2dac619
eedff77
78e5fb5
bb64cbc
8d838d8
13f6630
31dc853
10a33d5
a72e54d
8cd13b1
d372678
b9df71f
4547d5a
d5b1953
39ad0a8
a4597bf
64743bb
d1d7121
033a683
71756de
2be64dc
908a192
1a89af7
87a7702
4f1434d
ec1cfc4
a57ba2b
adc574b
452af59
2cf9efe
b046978
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the slice only needs to be altered once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the original code, and it seems the slicing is happening on the first axis of the array only. In my test case (Rosamond, 10/16/2022,
t064_135523_iw1
), the radargrid rasters' shapes were (109,418), anddec_factor
was 42.dec_slice
was as below:Below are the shapes of the decimated arrays:
So it seems we need to provide the slice instance twice for the 2d arrays. @vbrancat Can you take a look at the information above and confirm that the shape of the decimated array makes sense?
Below is a toy code to show how the slicing works in 2D numpy array:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I have fixed this in the next commit.