-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write CSLC raster and correction stats to HDF5 #120
Conversation
add iono and SET correction stat computations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe @vbrancat can give more comments about the structure.
I've left a small question regarding the correction data to include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we are still generating the JSON file for the stats. Would it be possible to remove it?
Do you prefer:
|
Let's keep the ability of generating the JSON file but let's not produce it |
also, shall we indicate that |
Currently the HDF5 doesn't include all the QA fields found in the JSON ( What do you think about consolidating all QA items under one
|
Yes, I like that. Be aware pixel_classification_percentages that this:
should go into the static layers topo product and not in CSLC |
For the sake of consistency, should I add
|
Absolutely, let's go for it. |
add common function write to HDF5 and dict
A couple of comments:
Is this intentional? For the RFI domain I was expecting a string.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having addressed my comments.
* write stats to HDF5 * add iono and SET correction stat computations * include RAiDER tropo correction in stat computations * add common function write to HDF5 and dict * add QA to static layers HDF5
This PR: