Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation script modified to handle both CSLC and static layer HDF5s #124

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

LiangJYu
Copy link
Contributor

This PR modifies compass.utils.validate_cslc, renamed to validate_products, to handle both CSLC and static layer HDF5s.

Usage:

CSLC: python -m compass.utils.validate_product -r <ref HDF5> -s <sec HDF5> -p CSLC

static layer: python -m compass.utils.validate_product -r <ref HDF5> -s <sec HDF5> -p static_layer

Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiangJYu for taking care of the validation of the static layer. I've left some suggestion and questions.
the PR looks good to me overall, so I will approve this PR to expedite the process.

src/compass/utils/validate_product.py Outdated Show resolved Hide resolved
src/compass/utils/validate_product.py Outdated Show resolved Hide resolved
src/compass/utils/validate_product.py Show resolved Hide resolved
LiangJYu and others added 3 commits March 22, 2023 20:57
Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com>
Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com>
Copy link
Contributor

@vbrancat vbrancat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrancat
Copy link
Contributor

Can we have the static_layer option spelled as static_layers

@LiangJYu LiangJYu merged commit 009d4fd into opera-adt:main Mar 23, 2023
@LiangJYu LiangJYu deleted the generalize_validation branch March 23, 2023 04:34
seongsujeong added a commit to seongsujeong/COMPASS that referenced this pull request Mar 31, 2023
…opera-adt#124)

* validation modified to handle both CSLC and static layer HDF5s
* Add hashbang to enable scripting

Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants