Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push builds to cog-preview #1383

Closed
wants to merge 1 commit into from

Conversation

nmohoric
Copy link
Member

This will fix cog-preview at dockerhub.

This would need corresponding DOCKER_EMAIL, DOCKER_USER, and DOCKER_PASSWORD settings setup in travis. You'd also need to turn off automatic builds at dockerhub.

Just an idea, feel free to close if you'd like to go about this differently.

@sourcelevel-bot
Copy link

Hello, @nmohoric! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2017

CLA assistant check
All committers have signed the CLA.

@nmohoric
Copy link
Member Author

I hadn't considered this is running a matrix, so it would upload a build for each run in the matrix.
It would also be uploading the test container which is probably not what we want.

There's really not a good way to only do this after all have completed.

This is probably closable and I can go back to the drawing board.

@christophermaier
Copy link
Collaborator

@nmohoric Hrmm, yeah, that does complicate things... One thing I had considered is reworking the Docker build process such that it was again possible to use just a docker build to get an image. I think the main sticking point is the presence of the new binary cogctl that we inject. I think that's used internally in a setup script, but we might be able to rework things so that's no longer required. Historically, we've also had the cogctl binary inside the cog image as a way to distribute it an make it easier for people to run (since installing it natively used to require having an Erlang VM in place, the setup of which isn't necessarily trivial). Now, however, cogctl is written in Python and distributed as a stand-alone binary, so that motivating force is pretty much gone now.

I think simplifying the image build process is probably worthwhile now. It makes it easier to have external automated services (like Docker Hub!) run builds, and makes it easier for community members to also build. I'll close this PR and create a new issue tracking that idea.

Thank you so much for taking a run at this, though, @nmohoric ! It's much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants