onboard b4mad-racing

[durandom]

operate-first/support#350

/hold

[durandom]

[root@edeb1e1db75c home]# opfcli create-project b4mad-racing b4mad -d 'B4mad Racing'
INFO[0000] group b4mad already exists (continuing)
INFO[0000] rolebinding already exists (continuing)
INFO[0000] writing namespace definition to /home/cluster-scope/base/core/namespaces/b4mad-racing
[root@edeb1e1db75c home]# cd cluster-scope/overlays/prod/smaug
bash: cd: cluster-scope/overlays/prod/smaug: No such file or directory
[root@edeb1e1db75c home]# cd cluster-scope/overlays/prod/
[root@edeb1e1db75c prod]# ls
common  emea  moc  osc
[root@edeb1e1db75c prod]# cd moc/smaug/
[root@edeb1e1db75c smaug]# ls
configmaps  groups  ingresscontrollers  kustomization.yaml  nodenetworkconfigurationpolicies  oauths  secret-generator.yaml  secrets  storageclasses  subscriptions
[root@edeb1e1db75c smaug]# kustomize edit add resource ../../../../base/core/namespaces/
Display all 109 possibilities? (y or n)
[root@edeb1e1db75c smaug]# kustomize edit add resource ../../../../base/core/namespaces/b4mad-racing

[durandom]

not sure why this touched all those lines.
see the cmds I've executed in the PR comments
they are copied from https://github.com/operate-first/hitchhikers-guide/blob/main/pages/onboarding_project.ipynb

[durandom]

@tumido @HumairAK is this because opfcli needs an update?

[HumairAK]

edit: sorry misread

it's because you used kustomize cli, it reformated the file, just add the line:
../../../../base/core/namespaces/b4mad-racing
alphabetically and it should be fine.

[HumairAK]

what's interesting is when I see this via the vscode github editor by pressing . on the pr, it doesn't show as massive of a diff.

[HumairAK]

this should be smaug

[HumairAK]

This might be a typo but:
can't have more than one namespace in a kustomization.yaml
the files in b4mad-racing/ should be sufficient

[HumairAK]

can you add this alphabetically? we should update the cli to take this into account

[durandom]

@HumairAK I've restarted the PR with just the documented commands (see commit messages)

[root@edeb1e1db75c smaug]# opfcli version
Name: opfcli
Version: v0.2.0
Git Commit Hash: a789dbd852
Build Date: 2021-07-07T14:56:34

[durandom]

I can edit the files manually, but would we then need to create a bug issue in the opfcli repo?

[HumairAK]

@durandom these commands:

configmaps  groups  ingresscontrollers  kustomization.yaml  nodenetworkconfigurationpolicies  oauths  secret-generator.yaml  secrets  storageclasses  subscriptions
[root@edeb1e1db75c smaug]# kustomize edit add resource ../../../../base/core/namespaces/
Display all 109 possibilities? (y or n)
[root@edeb1e1db75c smaug]# kustomize edit add resource ../../../../base/core/namespaces/b4mad-racing

will refactor the kustomization file alongside adding the entries, this part isn't handled by the opfcli yet so what I would suggest is to undo the changes to the kustomization in the smaug/ directory and manually add these files. We should update the notebook to not use the kustomize edit add command

[durandom]

/unhold

[HumairAK]

/lgtm
/approved

[durandom]

fixes operate-first/support#350

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment