📊 introduce metrics for the peribolos app #128
Conversation
sesheta
added
the
size/XL
| Probot: probotDefault, | ||
| }) | ||
| : new Server({ | ||
| webhookProxy: process.env.WEBHOOK_PROXY_URL, |
There was a problem hiding this comment.
This does not start the webhook proxy by itself. It doesn't instantiate the smee-client the same way as run() call does. I think you're missing something like:
const smee = process.env.WEBHOOK_PROXY_URL
? undefined
: new SmeeClient({
source: process.env.WEBHOOK_PROXY_URL || '',
target: 'http://localhost:3000/events',
logger: console,
});
const events = smee?.start();
...
process.env.WEBHOOK_PROXY_URL &&
[
`exit`,
`SIGINT`,
`SIGUSR1`,
`SIGUSR2`,
`uncaughtException`,
`SIGTERM`,
].forEach((_) => {
events?.close();
});to work aroud this.
There was a problem hiding this comment.
i have tested this out with my own smee setup, it works for me
is this something that didn't work for you?
|
|
||
| run(app); | ||
| async function startServer() { | ||
| const probotDefault = Probot.defaults({ |
There was a problem hiding this comment.
Can't we use createProbot() func instead?
There was a problem hiding this comment.
it is pretty much doing the same thing:
https://github.com/probot/probot/blob/7fd06d697503b45a56742aec3f4eb7e8157a7c7f/src/create-probot.ts#L36
|
/approve Additional changes will be addressed in a follow up PR. |
sesheta
added
the
approved
|
/hold |
sesheta
added
the
do-not-merge/hold
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
sesheta
removed
the
do-not-merge/hold
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
introduce metrics for the peribolos app
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com
Related-to: #58
#59
/metricsanytype for the variable it was prompting.Tested on local:
