Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update tasks for peribolos upstream change #163

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

SamoKopecky
Copy link
Member

@SamoKopecky SamoKopecky commented Jul 8, 2022

Resolves #150

  • Remove peribolos image from kustomization files and peribolos-fix directory since we no longer need it.
  • Add GitHub App auth to use with peribolos in dump-config and run tasks.
  • Remove CI/CD for peribolos.

@SamoKopecky
Copy link
Member Author

SamoKopecky commented Jul 8, 2022

Blocked by toolbox version.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2022
@SamoKopecky
Copy link
Member Author

/hold

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2022
@SamoKopecky SamoKopecky force-pushed the use-app-auth branch 2 times, most recently from 4b9b9ab to bb8a5ab Compare July 8, 2022 11:55
@SamoKopecky SamoKopecky changed the title feat(tasks): Use git auth in dump-config task feat: Update tasks for peribolos upstream change Jul 8, 2022
@SamoKopecky
Copy link
Member Author

/cc @tumido

@sesheta sesheta requested a review from tumido July 8, 2022 12:04
Signed-off-by: SamoKopecky <skopecky@redhat.com>
Signed-off-by: SamoKopecky <skopecky@redhat.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@sesheta
Copy link
Member

sesheta commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@tumido
Copy link
Member

tumido commented Jul 18, 2022

New toolbox build contains the required peribolos release.

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@sesheta sesheta merged commit b443b7c into operate-first:main Jul 18, 2022
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
# [1.3.0](v1.2.1...v1.3.0) (2022-12-08)

### Bug Fixes

* **deps:** pin dependency lru-cache to v7.13.1 ([#187](#187)) ([d0c1358](d0c1358))
* **deps:** update all non-major dependencies ([#195](#195)) ([5f0ca45](5f0ca45))
* Fix how metric labels are calculated ([3b51edc](3b51edc))
* Limit push events to .github repo only ([#175](#175)) ([d9f1b5e](d9f1b5e))
* Renew credentials on check retry ([#211](#211)) ([3c83e2b](3c83e2b))
* set --require-self to false on peribolos-run task ([#210](#210)) ([c19ed99](c19ed99))

### Features

* Add basic prometheus alerts ([#177](#177)) ([80e1129](80e1129))
* Add OCP link to check ([#183](#183)) ([ba545cc](ba545cc))
* Update tasks for peribolos upstream change ([#163](#163)) ([b443b7c](b443b7c))
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Marks issues as released label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. released Marks issues as released size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer downstream peribolos changes to upstream
3 participants