Revert cleanup spec and status fields #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
Some concerns were raised over whether this is or isn't a breaking change. It technically is a breaking change that we would normally deprecate first. But given that there wasn't an implementation to accompany this API perhaps removing it outright would be easier. |
Member
|
Is this cleanup field required? It doesn't appear so to me so it is not much of a breaking change as I thought it would be. |
|
@hasbro17: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
Member
|
Closing this since it's stale now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #100
The
spec.cleanupandstatus.cleanupAPI fields are no longer needed since the implementation for the server-side operand deletion work is on hold and unlikely to proceed per the original enhancement proposal.See: https://github.com/operator-framework/enhancements/pull/71/files