Add UID Optional field to scorecard config types #110
Conversation
Signed-off-by: Ish Shah <ishah@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: theishshah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -34,6 +34,8 @@ type StageConfiguration struct { | |||
| type TestConfiguration struct { | |||
| // Image is the name of the test image. | |||
| Image string `json:"image" yaml:"image"` | |||
| // UniqueID is is an optional unique test identifier of the test image. | |||
There was a problem hiding this comment.
Can you add an example of a default/generated value used if this is unset, and clarify where the default/generated value comes from?
There was a problem hiding this comment.
We are not going default this value, as it's not being used anywhere within scorecard and is only available as an option if someone wants to specifically tag a test and watch it with a unique id for that run.
There was a problem hiding this comment.
Does this value conform to any specifications, ex. DNS 1123? What do you mean by "watch it"? As a user, how and where is this value applied to my scorecard tests? Are there examples of what value I might set here?
These are some of the questions not answered by any documentation/godocs anywhere, which is kinda what I was getting at with my question. It isn't clear what this field does, and libraries should be self-descriptive.
Signed-off-by: Ish Shah <ishah@redhat.com>
openshift-ci
bot
added
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
Signed-off-by: Ish Shah <ishah@redhat.com>
jmrodri
dismissed
estroz’s stale review
All requested changes were made and questions answered.
Signed-off-by: Ish Shah <ishah@redhat.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri, theishshah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Create optional Unique ID field for Scorecard config types.