Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): Refactor CatalogSource controller #30

Merged
merged 4 commits into from
Apr 12, 2023
Merged

(chore): Refactor CatalogSource controller #30

merged 4 commits into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. refactor/cleanup controller logic 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1ea8464 View commit details
    Browse the repository at this point in the history

  2. revert how pod logs are read 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5cb17af View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. address review comments 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    f5f99c5 View commit details
    Browse the repository at this point in the history

  2. return error instead of nil 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6df3957 View commit details
    Browse the repository at this point in the history