-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ Remove TLSVerify/PullSecret fields #369
⚠ Remove TLSVerify/PullSecret fields #369
Conversation
I am working on switching We are also planning to port similar logic to I bring this up because there will be a way to inject pull secrets and insecure registry configurations to resolve the e2e issues (e.g. by mounting a configmap that contains the analogous configuration files for insecure registries and credentials) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 34.41% 34.48% +0.07%
==========================================
Files 17 17
Lines 738 722 -16
==========================================
- Hits 254 249 -5
+ Misses 452 443 -9
+ Partials 32 30 -2 ☔ View full report in Codecov by Sentry. |
@joelanford There was also changes to the way the e2es are configured in operator-controller recently that we might be able to update catalogd to follow. IIRC the changes in operator-controller made it so that we didn't need to skip TLS verification (since there is no way to set that in the |
Trying to just get the TLS/Cert changes from operator-controller in, before continuing here: |
PR to trust certs from image-registry: (Needs to be merged before and this rebased on top) |
182a8ac
to
093582b
Compare
093582b
to
26e7e4d
Compare
@thetechnick I've taken the liberty of rebasing your PR (please double check that my conflict resolution was what you had in mind =D) |
Remove fields that will not have long term support committed to them to prepare for the v1.0 release. Removed Fields: - spec.source.image.insecureSkipTLSVerify - spec.source.image.pullSecret GH Issue Ref: operator-framework#355 Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
26e7e4d
to
c6303d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1e962d2
Remove fields that will not have long term support committed to them to prepare for the v1.0 release.
Removed Fields:
GH Issue Ref: #355
Draft due to pending e2e test changes.