🌱 Add matchCondition to webhook config #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should add some efficiency as it only lets the webhook fire when needed Signed-off-by: Brett Tofel <btofel@redhat.com>
bentito
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 33.95% 33.95%
=======================================
Files 16 16
Lines 698 698
=======================================
Hits 237 237
Misses 435 435
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Merged
via the queue into
operator-framework:main
with commit Sep 5, 2024
6584e7e
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #370
Should add some efficiency as it only lets the webhook fire when needed.
If either the
olm.operatorframework.io/metadata.namelabel is missing, or the label does not match the catalog name, the webhook will be allowed to fire and correct the situation.