-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use default creds if present for pulling catalog images #416
Merged
joelanford
merged 1 commit into
operator-framework:main
from
anik120:support-private-registries
Sep 26, 2024
Merged
✨ Use default creds if present for pulling catalog images #416
joelanford
merged 1 commit into
operator-framework:main
from
anik120:support-private-registries
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 36.05% 35.65% -0.41%
==========================================
Files 14 14
Lines 796 805 +9
==========================================
Hits 287 287
- Misses 463 472 +9
Partials 46 46 ☔ View full report in Codecov by Sentry. |
anik120
force-pushed
the
support-private-registries
branch
from
September 26, 2024 12:26
6b8a3af
to
8cd2cf1
Compare
anik120
added a commit
to anik120/operator-framework-catalogd
that referenced
this pull request
Sep 26, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
anik120
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 26, 2024
RFC has been approved. |
joelanford
approved these changes
Sep 26, 2024
Merged
via the queue into
operator-framework:main
with commit Sep 26, 2024
a34f172
11 of 13 checks passed
anik120
added a commit
to anik120/operator-framework-catalogd
that referenced
this pull request
Sep 26, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift/operator-framework-catalogd
that referenced
this pull request
Sep 26, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
tmshort
pushed a commit
to tmshort/operator-framework-catalogd
that referenced
this pull request
Oct 7, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
openshift-bot
pushed a commit
to openshift-bot/operator-framework-catalogd
that referenced
this pull request
Oct 9, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
openshift-bot
pushed a commit
to openshift-bot/operator-framework-catalogd
that referenced
this pull request
Oct 14, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
openshift-bot
pushed a commit
to openshift-bot/operator-framework-catalogd
that referenced
this pull request
Oct 18, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
openshift-bot
pushed a commit
to openshift-bot/operator-framework-catalogd
that referenced
this pull request
Oct 19, 2024
MCO makes the global pull secrets available in `/var/lib/kubelet`. Catalogd will look for these secrets in `/etc/catalogd` folder, ref [catalogd:416](operator-framework/catalogd#416). This PR hostPath mounts the `/var/lib/kublet` directory from the host to the `/etc/catalogd` directory in the container's filesystem. RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing) Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.