Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use spec's ref instead of canonical ref when copying catalog image #438

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/source/containers_image.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (i *ContainersImageRegistry) Unpack(ctx context.Context, catalog *catalogdv
// copy.Image can concurrently pull all the layers.
//
//////////////////////////////////////////////////////
dockerRef, err := docker.NewReference(canonicalRef)
dockerRef, err := docker.NewReference(imgRef)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford I think it would be great to have the explanation from PR description somewhere in a comment here.

Does it make sense to unit test this scenario?

if err != nil {
return nil, fmt.Errorf("error creating source reference: %w", err)
}
Expand Down
Loading