Clean up handling of target namespaces #302
Assignees
Comments
metacosm
added a commit
that referenced
this issue
Jan 14, 2021
The intent here is that controllers should be registered according to their configuration. This will become even more relevant when externalized configuration is in place (see #237). This also means using ControllerConfiguration.WATCH_ALL_NAMESPACES_MARKER in the namespaces field of the Controller annotation where appropriate since that's what ControllerConfiguration uses to determine if a controller should watch all namespaces. This still needs to be unified across the code base (see #302).
metacosm
added a commit
that referenced
this issue
Jan 14, 2021
The intent here is that controllers should be registered according to their configuration. This will become even more relevant when externalized configuration is in place (see #237). This also means using ControllerConfiguration.WATCH_ALL_NAMESPACES_MARKER in the namespaces field of the Controller annotation where appropriate since that's what ControllerConfiguration uses to determine if a controller should watch all namespaces. This still needs to be unified across the code base (see #302).
metacosm
added a commit
that referenced
this issue
Jan 19, 2021
The intent here is that controllers should be registered according to their configuration. This will become even more relevant when externalized configuration is in place (see #237). This also means using ControllerConfiguration.WATCH_ALL_NAMESPACES_MARKER in the namespaces field of the Controller annotation where appropriate since that's what ControllerConfiguration uses to determine if a controller should watch all namespaces. This still needs to be unified across the code base (see #302).
metacosm
added a commit
that referenced
this issue
Jan 20, 2021
The intent here is that controllers should be registered according to their configuration. This will become even more relevant when externalized configuration is in place (see #237). This also means using ControllerConfiguration.WATCH_ALL_NAMESPACES_MARKER in the namespaces field of the Controller annotation where appropriate since that's what ControllerConfiguration uses to determine if a controller should watch all namespaces. This still needs to be unified across the code base (see #302).
|
The decision was made to keep the behavior where not specifying any namespace would result in all namespaces being watched by default by the controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to settle how we configure which namespace(s) a controller targets and how we configure this. Right now, there are conflicting versions, in particular when it comes to interpreting what no passed namespaces means.
ControllerConfigurationassumes that the current namespace is the target if the controller doesn't specify any, using theWATCH_ALL_NAMESPACES_MARKERto decide whether the controller watches all namespaces, while other parts of the code assume that if target namespaces is empty then that means that the controller should watch all namespaces.That historic behavior is problematic, in my opinion, because the default behavior for a controller should be to watch the namespace it is deployed on as it might not have privileges outside of that particular namespace.
We should also remove all the
registermethods onOperatorapart from this one which uses the controller's configuration to appropriately register the controller accordingly.The text was updated successfully, but these errors were encountered: