Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ObjectMapper in CustomResourceCache configurable #384

Closed
i8r opened this issue Mar 22, 2021 · 0 comments
Closed

Make ObjectMapper in CustomResourceCache configurable #384

i8r opened this issue Mar 22, 2021 · 0 comments

Comments

@i8r
Copy link

i8r commented Mar 22, 2021

The CustomResourceCache creates an internal ObjectMapper in order to clone objects. This causes problems if the default object mapper is not able to (de)serialize the sub-type of CustomResource. This happens for instance if the type has a field of Java 8 date/time types since com.fasterxml.jackson.datatype.jsr310.JavaTimeModule won't be loaded even if it is on the classpath.

I suggest to let the user of the library provide the instance of the ObjectMapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metacosm @i8r