feat: retry and retry configuration decoupling #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
approved these changes
Jun 15, 2022
Collaborator
metacosm
left a comment
metacosm
left a comment
There was a problem hiding this comment.
LGTM but this is a breaking change so we have to figure out when / how to introduce it…
Collaborator
Author
|
To be honest, I think we should define what API's we cover under semver, (this might be one). But because of this would not introduce a next major version for sure. So would stick with 3.1 tbh. |
Collaborator
Author
|
Will try to make it backwards compatible, and deprecate the old API. Then remove it in v4. |
Collaborator
|
I'm fine with sticking with 3.1 if it's too much trouble… Or this could wait for some later time… 🤷🏼 😀 |
|
Kudos, SonarCloud Quality Gate passed! |
csviri
added a commit
that referenced
this pull request
Jun 17, 2022
csviri
added a commit
that referenced
this pull request
Jun 27, 2022
Closed
csviri
added a commit
that referenced
this pull request
Jul 4, 2022
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.