Skip to content

fix: improved debug logging for getting from cache #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: improved debug logging for getting from cache #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...ava/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,17 @@ private void propagateEvent(R object) {
public Set<R> getSecondaryResources(P primary) {
Set<ResourceID> secondaryIDs;
if (useSecondaryToPrimaryIndex()) {
var primaryResourceID = ResourceID.fromResource(primary);
secondaryIDs =
primaryToSecondaryIndex.getSecondaryResources(ResourceID.fromResource(primary));
primaryToSecondaryIndex.getSecondaryResources(primaryResourceID);
log.debug(
"Using PrimaryToSecondaryIndex to find secondary resources for primary: {}. Found secondary ids: {} ",
primaryResourceID, secondaryIDs);
} else {
secondaryIDs = primaryToSecondaryMapper.toSecondaryResourceIDs(primary);
log.debug(
"Using PrimaryToSecondaryMapper to find secondary resources for primary: {}. Found secondary ids: {} ",
primary, secondaryIDs);
}
return secondaryIDs.stream().map(this::get).flatMap(Optional::stream)
.collect(Collectors.toSet());
Expand Down
4 changes: 3 additions & 1 deletion ...javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ public Optional<R> get(ResourceID resourceID) {
} else {
log.debug("Resource not found in temporary cache reading it from informer cache," +
" for Resource ID: {}", resourceID);
return cache.get(resourceID);
var res = cache.get(resourceID);
log.debug("Resource found in cache: {} for id: {}", res.isPresent(), resourceID);
return res;
}
}

Expand Down