Skip to content

improve: informer stop handler logging #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2023
Merged

improve: informer stop handler logging #1743

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6a357
docs: describe informer stop handler code
csviri Jan 30, 2023
57d5fb4
improved log message
csviri Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ default Optional<InformerStoppedHandler> getInformerStoppedHandler() {
log.error("Fatal error in informer: {}. Stopping the operator", informer, ex);
System.exit(1);
} else {
// In case informer is stopped on start (not synced) the controller will stop automatically.
// The case when already synced and stopped without an exception, can happen only if
// informer is stopped explicitly.
log.debug("Informer stopped: {}. Error: {}", informer, ex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some of this information should be put more explicitly in the log message?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

}
});
Expand Down