Skip to content

feat: Made ConfigurationServiceOverrider to accept dependent resource factory #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 29, 2023
Merged

feat: Made ConfigurationServiceOverrider to accept dependent resource factory #2175

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
157d74e
feat:Made ConfigurationServiceOverrider to accept dependent resource …
Dec 24, 2023
dba8aaa
Code refactor
Dec 24, 2023
b48d769
Format code
Dec 24, 2023
b082736
Merge branch 'main' into dependent-resource-factory-input
rameshmalla Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...e/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.client.KubernetesClient;
import io.javaoperatorsdk.operator.api.monitoring.Metrics;
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResourceFactory;

@SuppressWarnings("unused")
public class ConfigurationServiceOverrider {
Expand Down Expand Up @@ -39,6 +40,7 @@ public class ConfigurationServiceOverrider {
private Set<Class<? extends HasMetadata>> defaultNonSSAResource;
private Boolean previousAnnotationForDependentResources;
private Boolean parseResourceVersions;
private DependentResourceFactory dependentResourceFactory;

ConfigurationServiceOverrider(ConfigurationService original) {
this.original = original;
Expand Down Expand Up @@ -77,6 +79,12 @@ public ConfigurationServiceOverrider withMinConcurrentWorkflowExecutorThreads(in
return this;
}

public ConfigurationServiceOverrider withDependentResourceFactory(
DependentResourceFactory dependentResourceFactory) {
this.dependentResourceFactory = dependentResourceFactory;
return this;
}

public ConfigurationServiceOverrider withResourceCloner(Cloner cloner) {
this.cloner = cloner;
return this;
Expand Down Expand Up @@ -184,6 +192,12 @@ public boolean checkCRDAndValidateLocalModel() {
return checkCR != null ? checkCR : original.checkCRDAndValidateLocalModel();
}

@Override
public DependentResourceFactory dependentResourceFactory() {
return dependentResourceFactory != null ? dependentResourceFactory
: DependentResourceFactory.DEFAULT;
}

@Override
public int concurrentReconciliationThreads() {
return Utils.ensureValid(
Expand Down