Skip to content

improve: primary to secondary index edge case for dynamic mapper changes #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2024
Merged

improve: primary to secondary index edge case for dynamic mapper changes #2246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1888bab
improve: primary to secondary index edge case for dynamic mapper changes
csviri Feb 21, 2024
7e44bee
docs improvement
csviri Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...operatorsdk/operator/processing/event/source/informer/DefaultPrimaryToSecondaryIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ public synchronized void onDelete(R resource) {
primaryResources.forEach(
primaryResource -> {
var secondaryResources = index.get(primaryResource);
secondaryResources.remove(ResourceID.fromResource(resource));
if (secondaryResources.isEmpty()) {
index.remove(primaryResource);
// this can be null in just very special cases, like when the secondaryToPrimaryMapper is
// changing dynamically. Like if a list of ResourceIDs mapped dynamically extended in the
// mapper between the onAddOrUpdate and onDelete is called.
if (secondaryResources != null) {
secondaryResources.remove(ResourceID.fromResource(resource));
if (secondaryResources.isEmpty()) {
index.remove(primaryResource);
}
}
});
}
Expand Down