feat: e2e test to demonstrate namespace deletion problem fix #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
csviri
changed the title
csviri
force-pushed
the
controller-ns-deletion
branch
from
1d05db5
to
f9b15cb
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
csviri
changed the title
metacosm
reviewed
Sep 18, 2024
| } | ||
|
|
||
| private static boolean waitUntilResourcesDeleted() { | ||
| try (var client = new KubernetesClientBuilder().build()) { |
There was a problem hiding this comment.
Shouldn't we try to delay shutting down the informers and use them here instead of creating a new client?
There was a problem hiding this comment.
This is just a demonstration, of how the problems could be solved, thus without a change into to operator impl for now.
In a next iteration will come with a comprehensive solution. Note that to cover the whole cycle we need to delay of stop of reconciliation thus the whole operator so the finalizers are correctly removed.
limck5856
approved these changes
Sep 19, 2024
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
controller-ns-deletion
branch
from
050b4c5
to
3077268
Compare
metacosm
approved these changes
Sep 23, 2024
metacosm
pushed a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.