Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to Fabric8 7.0-SNAPSHOT for testing #2540

Closed
wants to merge 6 commits into from
Closed

chore: update to Fabric8 7.0-SNAPSHOT for testing #2540

wants to merge 6 commits into from

Conversation

metacosm
Copy link
Collaborator

Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm metacosm self-assigned this Sep 26, 2024
@metacosm metacosm requested review from csviri and xstefank September 26, 2024 08:14
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
xstefank
xstefank approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, just don't forget to update it before the release :)

@metacosm
chore: update to Fabric8 7.0-SNAPSHOT for testing
8106f53 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: wrong import
fa9154a 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
feat: replace CRD generator annotation processor by maven plugin
fa32301 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: also consider test classes when looking for CustomResources
e1feb41 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm mentioned this pull request Nov 29, 2024
Open
@baloo42 baloo42 mentioned this pull request Nov 30, 2024
Merged
baloo42 and others added 2 commits November 30, 2024 13:31
@baloo42
Fix CRD-Generator tests and examples (#2612)
2a55271 
Signed-off-by: Bernhard Strähle <bernhard.straehle@gmail.com>
@metacosm
fix: also consider test classes when looking for CustomResources
27b821e 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@baloo42 baloo42 mentioned this pull request Nov 30, 2024
Closed
@metacosm
Copy link
Collaborator Author

metacosm commented Dec 2, 2024

This change has been merged in next which is where it should have been to start with, so closing this PR.

@metacosm metacosm closed this Dec 2, 2024
@metacosm metacosm deleted the fabric8-7 branch December 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

@csviri csviri Awaiting requested review from csviri

Assignees

@metacosm metacosm

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metacosm @xstefank @baloo42