feat: allow easier configuration of matcher #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
reviewed
Apr 10, 2025
...io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
Outdated
Show resolved
Hide resolved
...io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
Outdated
Show resolved
Hide resolved
csviri
reviewed
Apr 11, 2025
|
|
||
| @SuppressWarnings("unchecked") | ||
| private SSABasedGenericKubernetesResourceMatcher<R> matcher = defaultMatcher; | ||
| private SSABasedGenericKubernetesResourceMatcher<R> matcher = |
There was a problem hiding this comment.
Shouldn't this be this rather part of the configuration?
The current approach is that name and class and config are the params and configuration contains everything else. This might go there just as well.
There was a problem hiding this comment.
Wanted to keep it simple first but it definitely could go on the config.
There was a problem hiding this comment.
@metacosm do you to do this change?
There was a problem hiding this comment.
Yes, I made it so it is now configured instead of settable manually.
csviri
reviewed
Apr 11, 2025
...io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm
force-pushed
the
config-matcher
branch
from
a9ee453 to
4f9c19d
Compare
|
Might be nice to see this on some integration test also. (But since it is only a configuration value it is not necessary) |
csviri
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com