Skip to content

Conversation

metacosm
Copy link
Collaborator

Signed-off-by: Chris Laprun claprun@redhat.com

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this May 16, 2025
@metacosm metacosm requested review from csviri and xstefank May 16, 2025 14:27
@csviri
Copy link
Collaborator

csviri commented May 16, 2025

Hmm didn't we move the matcher to configuration object?

@metacosm
Copy link
Collaborator Author

Hmm didn't we move the matcher to configuration object?

This is the configuration object.

@csviri
Copy link
Collaborator

csviri commented May 16, 2025

I mean if we can remove the constructor below.

@metacosm
Copy link
Collaborator Author

I mean if we can remove the constructor below.

No, it's needed by both the builder and the converter.

@metacosm metacosm merged commit 0aeb314 into main May 19, 2025
25 checks passed
@metacosm metacosm deleted the restore-backwards-compatibility branch May 19, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants