feat: expectation pattern support #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Closed
csviri
force-pushed
the
expectation-simple
branch
from
90bebc4 to
ac807a7
Compare
csviri
changed the title
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
6b9d9a3 to
4da5d2b
Compare
openshift-merge-robot
removed
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
ca4c8a2 to
c3c33bc
Compare
csviri
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
838d1a3 to
4c1de74
Compare
openshift-merge-robot
removed
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
cfde8f5 to
603ac9d
Compare
xstefank
requested changes
Oct 31, 2025
.../src/main/java/io/javaoperatorsdk/operator/processing/expectation/RegisteredExpectation.java
Show resolved
Hide resolved
...src/test/java/io/javaoperatorsdk/operator/processing/expectation/ExpectationManagerTest.java
Show resolved
Hide resolved
...src/test/java/io/javaoperatorsdk/operator/processing/expectation/ExpectationManagerTest.java
Show resolved
Hide resolved
...src/test/java/io/javaoperatorsdk/operator/processing/expectation/ExpectationManagerTest.java
Outdated
Show resolved
Hide resolved
| return UpdateControl.noUpdate(); | ||
| } | ||
| } else { | ||
| // checks the expectation if it is fulfilled also removes it, |
Collaborator
Author
There was a problem hiding this comment.
not sure what do you mean... pls ellaborate
Collaborator
There was a problem hiding this comment.
basically I wrote everything the code in the docs - #2941 (comment), so just do the same in the original code that the docs refference.
Collaborator
There was a problem hiding this comment.
this is still not fixed, but leave it be, I'll fix it after the PR is merged
Collaborator
Author
|
thank you @xstefank for all the fixes in javadocs and other suggestions!! |
csviri
force-pushed
the
expectation-simple
branch
from
4149721 to
fda19a2
Compare
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
expectation-simple
branch
from
fda19a2 to
98f92ba
Compare
I just want to test if this really allows me to commit to your PR branch. It's not a big change.
xstefank
reviewed
Nov 14, 2025
...ework-core/src/main/java/io/javaoperatorsdk/operator/processing/expectation/Expectation.java
Show resolved
Hide resolved
...core/src/main/java/io/javaoperatorsdk/operator/processing/expectation/ExpectationStatus.java
Show resolved
Hide resolved
...va/io/javaoperatorsdk/operator/processing/expectation/PeriodicCleanerExpectationManager.java
Outdated
Show resolved
Hide resolved
...va/io/javaoperatorsdk/operator/processing/expectation/PeriodicCleanerExpectationManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
…tor/processing/expectation/PeriodicCleanerExpectationManager.java Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Nov 18, 2025
| return UpdateControl.noUpdate(); | ||
| } | ||
| } else { | ||
| // checks the expectation if it is fulfilled also removes it, |
Collaborator
There was a problem hiding this comment.
this is still not fixed, but leave it be, I'll fix it after the PR is merged
csviri
added a commit
that referenced
this pull request
Nov 20, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue