Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2025

Improved way to add finalizers:

  • Gets the resource on retry from informer cache not a separate API call, so reduces the number of Kubernetes API calls
  • Caches the updated resource, making sure it is available for next reconiliation

TODO:

  • check if finalizer already there when retrying
  • discuss: have this as default way of adding finalizers (behind feature flag?)

csviri and others added 9 commits September 2, 2025 13:15
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
this was added to fabric8 client meanwhile

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
)

* feature: add AggregatedMetrics to support multiple Metrics implementations


Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
)

Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@csviri csviri changed the base branch from main to next September 17, 2025 11:27
@csviri csviri changed the title new finalizer add feat: experimental utility methods to add finalizer Sep 17, 2025
@csviri csviri changed the title feat: experimental utility methods to add finalizer [WIP] feat: experimental utility methods to add finalizer Sep 17, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants