Skip to content

[WIP] feat: experimental utility methods to add finalizer #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Parent: improve: refining resource version comparison
wants to merge 10 commits into
base: next
Choose a base branch
from
Draft

[WIP] feat: experimental utility methods to add finalizer #2948

wants to merge 10 commits into from

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2025 •
edited
Loading

Improved way to add finalizers:

  • Gets the resource on retry from informer cache not a separate API call, so reduces the number of Kubernetes API calls
  • Caches the updated resource, making sure it is available for next reconiliation

TODO:

  • check if finalizer already there when retrying
  • discuss: have this as default way of adding finalizers (behind feature flag?)

csviri and others added 9 commits September 2, 2025 13:15
@csviri
feat: field selectors support for InformerEventSource (#2835)
ce0be66 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
improve: remove owner refernce check (#2838)
38f7df6 
this was added to fabric8 client meanwhile

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@Donnerbart @csviri
Add AggregatedMetrics to support multiple Metrics implementations (#2917
0dddeee 
)

* feature: add AggregatedMetrics to support multiple Metrics implementations


Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
@xstefank @metacosm @csviri
feat: allow overriding test infrastructure kube client separately (#2764
e0f8b5b 
)

Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
improve: duration for initial interval in GenericRetry (#2929)
c0f9db0 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
improve: GenericRetry does not provide mutable singleton instance (#2934
bba30f9 
)
@metacosm
chore(deps): update to Fabric8 client 7.4.0 (#2937)
205f001 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
feat: add experimental annotation (#2853)
4aa17d4 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
feat: experimental utility methods to add finalizer
d4f431d 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@csviri csviri changed the base branch from main to next September 17, 2025 11:27
@csviri csviri changed the title new finalizer add feat: experimental utility methods to add finalizer Sep 17, 2025
@csviri csviri changed the title feat: experimental utility methods to add finalizer [WIP] feat: experimental utility methods to add finalizer Sep 17, 2025
@csviri
format
1149282 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2025
@csviri csviri force-pushed the next branch 2 times, most recently from 3075f11 to 4972764 Compare October 23, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csviri @openshift-merge-robot @Donnerbart @xstefank @metacosm