Resource version comparison utility #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Should this include the numeric sanity checks as well? |
added, it is not perfect this way, but I would say good enough, what do you think? |
shawkins
reviewed
Oct 10, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Outdated
Show resolved
Hide resolved
shawkins
reviewed
Oct 10, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Outdated
Show resolved
Hide resolved
shawkins
reviewed
Oct 10, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Outdated
Show resolved
Hide resolved
csviri
commented
Oct 10, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Show resolved
Hide resolved
xstefank
approved these changes
Oct 13, 2025
...src/test/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtilsTest.java
Outdated
Show resolved
Hide resolved
csviri
force-pushed
the
comparator-function
branch
from
73747c9 to
11be6a4
Compare
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
…tor/api/reconciler/PrimaryUpdateAndCacheUtils.java Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
…tor/api/reconciler/PrimaryUpdateAndCacheUtils.java Co-authored-by: Steven Hawkins <shawkins@redhat.com>
…tor/api/reconciler/PrimaryUpdateAndCacheUtils.java Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
…tor/api/reconciler/PrimaryUpdateAndCacheUtilsTest.java Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
comparator-function
branch
from
ea46082 to
808f6d9
Compare
shawkins
approved these changes
Oct 14, 2025
xstefank
requested changes
Oct 15, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Outdated
Show resolved
Hide resolved
…tor/api/reconciler/PrimaryUpdateAndCacheUtils.java Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
xstefank
approved these changes
Oct 15, 2025
|
@metacosm can we merge this? |
csviri
added a commit
that referenced
this pull request
Oct 18, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Co-authored-by: Steven Hawkins <shawkins@redhat.com>
csviri
added a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEP compatible implementation of resourceVersion comparator: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5504-comparable-resource-version#helper-function