Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dekorate in the Spring Boot example and add documentation #27

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Use Dekorate in the Spring Boot example and add documentation #27

merged 5 commits into from
Jul 13, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Jul 12, 2022 •
edited
Loading

These changes are only about adding documentation for the Spring Boot example.
Out of scope:

  • I didn't do any improvements in the framework as I would like to understand better where we are.
  • I will document the Quarkus example later in a separate pull request.
  • Add the steps from the documentation to be done automatically in the CI

@Sgitario Sgitario force-pushed the doc_spring_boot_example branch from 90ada07 to 8600e5c Compare July 12, 2022 11:24
@snowdrop-bot snowdrop-bot mentioned this pull request Jul 12, 2022
Open
csviri
csviri approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor comments otherwise LGTM

...main/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/AdmissionControllerConfig.java Outdated Show resolved Hide resolved
samples/spring-boot/Dockerfile Outdated Show resolved Hide resolved
@Sgitario Sgitario requested a review from csviri July 13, 2022 05:00
csviri
csviri approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit ff8836d into operator-framework:main Jul 13, 2022
@Sgitario Sgitario deleted the doc_spring_boot_example branch July 14, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sgitario @csviri