GH Actions CI and release improvements #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
- Make sure bin directory exists prior to attempting binary fetches - Bump versions of goreleaser and krew-release-bot - Share goreleaser workflow for PRs, branch pushes, and tags, but with configuration based on event type Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
fix-release-workflow
branch
from
f9594a4 to
bb74318
Compare
joelanford
changed the title
grokspawn
approved these changes
Nov 17, 2023
|
/lgtm |
openshift-merge-bot
bot
merged commit 641f976
into
operator-framework:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we released v0.5.0, the release action failed because the
/bindirectory was not pre-created.Something seems to have changed outside our repo to cause this to break, because this worked before. For now, let's just make sure we create this directory in advance of trying to untar into it.
While we're at it, also: