Convert boolean fields to enums

[everettraven]

As outlined in the Do not use Boolean Fields subsection of the OpenShift API Conventions, boolean fields are to be replaced with an enumeration of values that describe the action instead.

At the time of writing this issue, the only field that is boolean type is the ClusterExtension.Spec.Preflight.CRDUpgradeSafety.Disabled field:

operator-controller/api/v1alpha1/clusterextension_types.go

Line 112 in cb9ea00

Disabled bool `json:"disabled,omitempty"`

This field should be updated to use an enumeration instead.

For inspiration, an implementation could look something like:

type CRDUpgradeSafetyPolicy string 

const (
  CRDUpgradeSafetyPolicyEnabled CRDUpgradeSafetyPolicy = "Enabled"
  CRDUpgradeSafetyPolicyDisabled CRDUpgradeSafetyPolicy = "Disabled"
)

type CRDUpgradeSafetyPreflightConfig struct {
  //+kubebuilder:Required
  // +kubebuilder:validation:Enum:="Enabled","Disabled"
  // policy represents the state of the CRD upgrade safety preflight check. Allowed values are "Enabled", and Disabled".
  Policy CRDUpgradeSafetyPolicy `json:"policy,omitempty"`
}

[yashoza19]

/assign