-
Notifications
You must be signed in to change notification settings - Fork 68
Description
As outlined in the Pointers subsection of the OpenShift API Conventions, in configuration APIs, pointers should only be used when there is an explicit need to distinguish between a zero value and a nil value. An exception here is pointers in the Status subresource since a nil value has a different meaning in the Status subresource than the Spec.
We propose that the following fields, not having the explicit need to distinguish between the zero and nil values, should be updated to no longer be pointers:
The following fields do not have the explicit need to distinguish between the zero and nil values, meaning they should be updated to no longer be pointers based on the OpenShift API Conventions:
ClusterExtension.Spec.Preflight:operator-controller/api/v1alpha1/clusterextension_types.go
Lines 84 to 85 in baac660
// Preflight defines the configuration of preflight checks. Preflight *PreflightConfig `json:"preflight,omitempty"` ClusterExtension.Spec.Preflight.CRDUpgradeSafety:operator-controller/api/v1alpha1/clusterextension_types.go
Lines 103 to 105 in baac660
//+kubebuilder:Required // CRDUpgradeSafety holds necessary configuration for the CRD Upgrade Safety preflight checks. CRDUpgradeSafety *CRDUpgradeSafetyPreflightConfig `json:"crdUpgradeSafety,omitempty"`
Metadata
Metadata
Assignees
Labels
Type
Projects
Status