e2e flake: [FAILED] Operator Install when An operator is installed from an operator catalog

[joelanford]

See: https://github.com/operator-framework/operator-controller/actions/runs/4990417752/jobs/8938348906#step:4:522

• [FAILED] [181.699 seconds]
Operator Install when An operator is installed from an operator catalog [It] resolves the specified package with correct bundle path
/home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:64

  Timeline >>
  STEP: creating the Operator resource @ 05/16/23 12:15:10.141
  STEP: eventually reporting a successful resolution and bundle path @ 05/16/23 12:15:10.145
  [FAILED] in [It] - /home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:75 @ 05/16/23 12:15:40.147
  << Timeline

  [FAILED] Timed out after 30.001s.
  The function passed to Eventually failed at /home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:74 with:
  Expected
      <string>: package 'argocd-operator' not found
  to equal
      <string>: install was successful
  In [It] at: /home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:75 @ 05/16/23 12:15:40.147
------------------------------

Summarizing 1 Failure:
  [FAIL] Operator Install when An operator is installed from an operator catalog [It] resolves the specified package with correct bundle path
  /home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:75

[tmshort]

From @joelanford.

Issues:

• The image is pulled from a public image registry over the internet (is quay up? are we being rate-limited?)
• The image is big (is it taking too long to download/unpack?)
• The image is always changing and we don’t control the content of it (did the thing we depend on change?)

Things to look at:

1. Put the image contents + image build in the repo (and then use kind load to get it into the e2e cluster)
2. Keep the image contents small
3. Keep the image contents focused on what we’re actually testing

[joelanford]

Put the image contents + image build in the repo (and then use kind load to get it into the e2e cluster)

Doing this part requires a catalogd release that includes operator-framework/catalogd#65