-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move all e2e scripts into one location #1046
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 32 32
Lines 1884 1884
=======================================
Hits 1366 1366
Misses 383 383
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I would actually suggest moving from |
I moved it into hack because we use But I'm not opposed into getting rid of |
Just my 2c (nothing blocking), seems the As an alternative, we could also move test/tools to /hack/test - and have a hack/misc for more specific purposed, non-critical-path, type scripts. |
I'd be ok with |
@m1kola ? |
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Sorry, something more urgent/importnat came up and I was focusing on it. Moved everything into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Description
Follow up for #1003 (review).
Some of the e2e scripts were in
./hack
and some were in./test/tools
. Moved everything into single location. Everything is in./hack/test
now.Reviewer Checklist