Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 4, 2024

It's only in the docs.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

It's only in the docs.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner September 4, 2024 15:44
@netlify
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit aac76b9
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d89e52ae36820008c30736
😎 Deploy Preview https://deploy-preview-1214--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (554b1a0) to head (aac76b9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   77.58%   77.51%   -0.08%     
==========================================
  Files          36       36              
  Lines        1981     1979       -2     
==========================================
- Hits         1537     1534       -3     
- Misses        309      310       +1     
  Partials      135      135              
Flag Coverage Δ
e2e 57.55% <ø> (-0.15%) ⬇️
unit 56.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn added this pull request to the merge queue Sep 4, 2024
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Sep 4, 2024
Co-authored-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn enabled auto-merge September 4, 2024 17:58
@grokspawn grokspawn added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@tmshort tmshort added this pull request to the merge queue Sep 4, 2024
Merged via the queue into operator-framework:main with commit a28d932 Sep 4, 2024
@tmshort tmshort deleted the remove-phase branch September 4, 2024 18:54
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants