🐛 Update go version checker #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle new files (old version is empty) * Handle the case where .0 patch is added/removed Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
approved these changes
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
=======================================
Coverage 74.73% 74.73%
=======================================
Files 42 42
Lines 3241 3241
=======================================
Hits 2422 2422
Misses 646 646
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rashmi43
added a commit
to rashmi43/operator-controller
that referenced
this pull request
Nov 19, 2024
Update go version checker (operator-framework#1474) * Handle new files (old version is empty) * Handle the case where .0 patch is added/removed Signed-off-by: Todd Short <tshort@redhat.com> sa not found Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> 📖 Document OLMv1 permission model (operator-framework#1380) * changes to derice minimum service account Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * remove headers Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * add details about registry+v1 support * render yml correctly Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * create doc for olmv1 permission model Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * Delete docs/drafts directory * Update permission-model.md * update permission models with link Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * add space Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * add more structure Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * incorporate review comments Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * incorporate review comments Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> * pers review comments-s * example as header-s * update the example Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> --------- Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com> Delete docs/drafts/derive-serviceaccount.md add custom sa not found Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist