🐛 renamed catalogd service name in download-catalog hack script #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
azych
changed the title
camilamacedo86
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 42 42
Lines 3329 3329
=======================================
Hits 2472 2472
Misses 676 676
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
approved these changes
Jan 7, 2025
Merged
via the queue into
operator-framework:main
with commit Jan 7, 2025
83b01c3
18 of 19 checks passed
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…perator-framework#1545) Co-authored-by: Artur Zych <5843875+azych@users.noreply.github.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…perator-framework#1545) Co-authored-by: Artur Zych <5843875+azych@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix that changes the name of the catalogd service from
catalogd-serverto the currently usedcatalogd-servicein the hack/tools/catalogs/download-catalog script.Changes separated from #1539 as per #1539 (comment)
Reviewer Checklist