Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 14, 2025

This PR only move the relevant content from Catalogd README ( quick start and demo ) to the root README centralizing both and update the places where the old catalogd repo was referenced.

Closes: #1339
Closes: #1602

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 14, 2025 12:42
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b5e7d00
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6788f110bd9f2700088628d4
😎 Deploy Preview https://deploy-preview-1612--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 force-pushed the update-docs-monorepo branch 2 times, most recently from 905d0eb to 8dea29f Compare January 14, 2025 12:51
@camilamacedo86
Copy link
Contributor Author

@michaelryanpeter

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.71%. Comparing base (1bbc6cb) to head (b5e7d00).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
+ Coverage   66.69%   66.71%   +0.02%     
==========================================
  Files          57       57              
  Lines        4588     4588              
==========================================
+ Hits         3060     3061       +1     
+ Misses       1303     1302       -1     
  Partials      225      225              
Flag Coverage Δ
e2e 52.66% <ø> (-0.09%) ⬇️
unit 53.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


* Access to a Kubernetes cluster, for example `kind`, using an account with `cluster-admin` permissions
* [Operator Controller installed](https://github.com/operator-framework/operator-controller/releases) on the cluster
* [Catalogd installed](https://github.com/operator-framework/catalogd/releases/) on the cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idt this whole line should go away, catd is still needed on the cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 1 project now.
The release of https://github.com/operator-framework/operator-controller/releases will end up a file with both projects. So, I updated it for

Copy link
Contributor

@makon57 makon57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left some comments nothing that needs serious change. Things to note is just consistency in how we reference things but looks like everything that needs change for catalogs repo was done.


Thank you for your interest in contributing to the Operator-Controller.

As you may or may not know, the Operator-Controller project aims to deliver the user experience described in the [Operator Lifecycle Manager (OLM) V1 Product Requirements Document (PRD)](https://docs.google.com/document/d/1-vsZ2dAODNfoHb7Nf0fbYeKDF7DUqEzS9HqgeMCvbDs/edit). The design requirements captured in the OLM V1 PRD were born from customer and community feedback based on the experience they had with the released version of [OLM V0](https://github.com/operator-framework/operator-lifecycle-manager).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are inconsistencies in how we reference OLM v1/V1 or v0/V0? Maybe stick to lowercase (OLM v1 & OLM v0) as that is the case with all the other docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @makon57,

Thank you for pointing this out—you’re absolutely right!
However, I think this might go beyond the scope of this PR.

What do you think about raising a separate PR to ensure we describe it consistently across all relevant places?
Would you like to work on that? It would be great to have your contribution to this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. While there are definitely updates that need to be made (for e.g. AFAIK the whole PRD needs an update) the scope of this PR is pretty focused on the monorepo reorganization.
Would absolutely welcome a PR (or more) to address other issues.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
- Replaced references to https://github.com/operator-framework/catalogd/ across the documentation.
- Ensures that all mentions of the old catalogd repository are correctly updated.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
camilamacedo86 and others added 4 commits January 16, 2025 11:42
- Integrated relevant content from catalogd/README.md into the project's main README by adding Demo and Quick-Start steps from catalogd/README.md to the main README.
- Removed the old catalogd/README.md as its remaining content (e.g., contribution guidelines) is already covered in CONTRIBUTING.md.
Co-authored-by: Jordan Keister
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
…now we have only one service

Co-authored-by: Brett Tofel <btofel@redhat.com>
- Update catalogd/docs/fetching-catalog-contents.md
- Updare docs/tutorials/add-catalog.md
@camilamacedo86
Copy link
Contributor Author

I am moving forward. We can always pushfollow-ups if we need to do so.

@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into operator-framework:main with commit f8206bf Jan 17, 2025
24 checks passed
@camilamacedo86 camilamacedo86 deleted the update-docs-monorepo branch January 17, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monorepo documentation updates
7 participants