✨ Add support for deploying OCI helm charts in OLM v1 #1971
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
- Coverage 69.11% 68.13% -0.98%
==========================================
Files 79 80 +1
Lines 7023 7197 +174
==========================================
+ Hits 4854 4904 +50
- Misses 1887 2002 +115
- Partials 282 291 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OchiengEd
force-pushed
the
helm_explorations
branch
from
3b36dfb to
272dcbf
Compare
internal/shared/util/image/pull.go
Outdated
| if hasChart(img) { | ||
| return pullChart(ctx, ownerID, imgSrc, canonicalRef, cache, layoutDir) | ||
| } | ||
|
|
||
| // Helm charts would error when getting OCI config |
There was a problem hiding this comment.
This tells me that our cache Store interface method is too specific. We need to make that generic enough to accommodate registry+v1 bundles and OCI helm charts as a first step, and rebase the feature-gated helm support on top.
There was a problem hiding this comment.
Making the Cache interface generic enough to be able to store both Helm charts and OCI images is inevitable. Will be looking at that at some point
OchiengEd
force-pushed
the
helm_explorations
branch
from
272dcbf to
39948a0
Compare
| @@ -29,6 +29,7 @@ type LayerData struct { | |||
| } | |||
|
|
|||
| type Cache interface { | |||
| ExtendCache | |||
There was a problem hiding this comment.
Is that valid for any or only Helm
Would be better we rename it like ChartCache, something like?
There was a problem hiding this comment.
Only for Helm charts at this time. We would need to see if it is possible to refactor the Store() method in the Cache interface to be able to store both Helm charts and OCI images to the cache.
OchiengEd
force-pushed
the
helm_explorations
branch
from
39948a0 to
5aa38f7
Compare
* added support for deploying OCI helm charts which sits behind the HelmChartSupport feature gate * extended the Cache interface to allow storing of Helm charts * inspect chart archive contents Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
OchiengEd
force-pushed
the
helm_explorations
branch
from
5aa38f7 to
5f58c8e
Compare
Description
This pull request aims to add logic to OLM v1 for handling OCI Helm chart support. We expect more work to go into this feature as further discussion on this occurs on issue #962 and the Arbitrary Configuration RFC which may inform how
values.ymlwould be passed to Helm charts.Reviewer Checklist