Skip to content

Conversation

camilamacedo86
Copy link
Contributor

No description provided.

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner June 23, 2025 16:57
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c0b99b9
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685addd957d1a50008a6eb56
😎 Deploy Preview https://deploy-preview-2037--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86 camilamacedo86 changed the title ✨ Upgrade MINOR versions for bingo via make bingo-upgrade and re-generate manifests with controller-gen v0.18.0 WIP Jun 23, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.82%. Comparing base (20d0880) to head (c0b99b9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2037       +/-   ##
===========================================
+ Coverage   60.24%   73.82%   +13.57%     
===========================================
  Files          81       81               
  Lines        7365     7365               
===========================================
+ Hits         4437     5437     +1000     
+ Misses       2702     1588     -1114     
- Partials      226      340      +114     
Flag Coverage Δ
e2e 44.06% <ø> (?)
unit 60.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title WIP 🌱 Upgrade bingo deps Jun 24, 2025
module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.23.0
go 1.24.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish that this is what our root go.mod resolved to as well (in terms of go/toolchain). 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I follow it
Do you think that is wrong?
Is it to be changed?
How?

Copy link
Contributor

@grokspawn grokspawn Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do here. Just wishing that each of our components expressed a dependency on the 0th patchlevel for the golang version, and the toolchain (if needed) expressed the higher version for additional dependencies.

@tmshort
Copy link
Contributor

tmshort commented Jun 25, 2025

Note that #2047 updates kind.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/spprove

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a2afaea into operator-framework:main Jun 26, 2025
21 of 22 checks passed
@camilamacedo86 camilamacedo86 deleted the bingo branch June 27, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants