Skip to content

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner June 24, 2025 16:11
Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 62b83d7
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685adc2177652000088a8491
😎 Deploy Preview https://deploy-preview-2044--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.80%. Comparing base (20d0880) to head (62b83d7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2044       +/-   ##
===========================================
+ Coverage   60.24%   73.80%   +13.56%     
===========================================
  Files          81       81               
  Lines        7365     7365               
===========================================
+ Hits         4437     5436      +999     
+ Misses       2702     1589     -1113     
- Partials      226      340      +114     
Flag Coverage Δ
e2e 44.10% <ø> (?)
unit 60.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title (Blocked) ✨ Upgrade sigs.k8s.io/controller-tools from v0.17.1 to v0.18.0 ✨ Upgrade sigs.k8s.io/controller-tools from v0.17.1 to v0.18.0 Jun 24, 2025
@camilamacedo86 camilamacedo86 changed the title ✨ Upgrade sigs.k8s.io/controller-tools from v0.17.1 to v0.18.0 🌱 Upgrade sigs.k8s.io/controller-tools from v0.17.1 to v0.18.0 Jun 26, 2025
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fca620f into operator-framework:main Jun 26, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants