Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 26, 2025

It's already part of the catalogd base config.

This was a leftover from the monorepo effort.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

It's akready part of the catalogd base config.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 26, 2025 17:45
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2336f26
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685d87272407170008664915
😎 Deploy Preview https://deploy-preview-2055--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from joelanford and oceanc80 June 26, 2025 17:45
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.80%. Comparing base (10f4a19) to head (2336f26).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files          81       81           
  Lines        7365     7365           
=======================================
  Hits         5436     5436           
  Misses       1589     1589           
  Partials      340      340           
Flag Coverage Δ
e2e 44.06% <ø> (-0.05%) ⬇️
unit 60.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Contributor

This one looks good, but I have to ask

  1. how did you spot the webhook as unused? Was it just the Mk1 Eyeball approach?
  2. could we apply the same assessment on other content (if less labor-intensive than the Mk1 Eyeball)?

/lgtm

In future, it would be helpful to have a little more description in the PR

@openshift-merge-bot openshift-merge-bot bot merged commit ab24788 into operator-framework:main Jun 26, 2025
21 checks passed
@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2025

@grokspawn it was eyeballs through research for the feature-gated APIs. I noted that this was unused, and is a leftover from the monorepo effort.

@tmshort tmshort deleted the rm-webhook branch June 26, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants